dingwat has quit [Quit: Connection closed for inactivity]
sgstair_ has quit [Ping timeout: 244 seconds]
sgstair has joined #scopehal
eightdot has joined #scopehal
<eightdot>
azonenberg: i tried quadrature encode decoding, on a agilent MSO-X4154(iirc) the goot news is: talking to the scope works!
<eightdot>
the sad news: b) decoder segfaults (i have a workaround, but doubt if i 'fixed' it the right way;
<eightdot>
c) i think there is a smal bug in wraparound, it does +180->-180 in one turn , and -180->+180 in multi turn (i think i have a fix)
<eightdot>
d) toggling one channel makes the count drift, i 'fixed' this by implementing counting on all 4 phases
<eightdot>
i will try and send some pull requests/bugreports next week..
<eightdot>
b) crashes on cap->m_samples.push_back(cap->m_samples[ilast]); (i think because push_bash reallocates the array, and then the pass-by-rev point to the old array)
<eightdot>
c) i 'fixed' by changing if(rmode == MODE_MULTI_REV) to if(rmode == MODE_SINGLE_REV) (line 238)
<eightdot>
d) line 150 says: "//TODO: add mode to say look for both edges or only rising", my question is: do we want to keep the current way of counting (and add a 4 phase mode) or do we want to switch to 4 pashe counting (as the only option)
<azonenberg>
hmm
<azonenberg>
I think it might make sense to unify it to only do +/- 180 because we now have a separate filter for unwrapped phase angle calculation