13:43 <diederik> If you (currently) buy a FriendlyElec NanoPi R5S, I'm pretty sure you'd get the LTS version. AFAICT the LTS version only has a reset button and an IR receiver added. Should those be added to rk3568-nanopi-r5s.dts or should they be put into a new rk3568-nanopi-r5s-lts.dts file?

13:45 <diederik> It looks like the (publicly) available schematic is for the non-LTS version (reset-button ("GPIO4_A0_K1") is marked as NC)

13:48 <diederik> In the pinctrl node, I added ``reset_button_pin: gpio4-a0-k1`` or should I make that ``gpio4_a0_k1: gpio4-a0-k1`` ? (as "GPIO4_A0_K1" is used in the schematic)

15:28 <mmind00> diederik: so the reset-button is already on the original schematics?

15:28 <mmind00> i.e. someone _could_ solder a button to the pad? :-)

15:29 <mmind00> diederik: for the pinctrl thing, please just use the schematics naming ... i.e. your 2nd option above

15:39 <diederik> mmind00: It's there, just a bit hard to identify it as the reset button (I actually derrived it from the R5C). Will swich to the 2nd option for pinctrl

15:41 <mmind00> diederik: so if it's there (just unpopulated) on the original board, I'd think it can go into the existing dts ... just maybe make a note about the NC part

15:41 <diederik> Dunno if soldering a button is an option on the non-lts variant though. But I'll add the button the existing dts file. If someone wants to 'reorganize' it later, that can still happen

15:42 <diederik> mmind00: I really don't know. I don't have a component placement diagram and no access to a non-LTS board

15:43 <diederik> Will make a note about the NC part as I'm enabling something which according to the currently available schematic is NC ... yet it works on my board :)

15:43 <mmind00> yep, sounds great then

15:43 <diederik> thanks :)

16:35 <CounterPillow> https://lore.kernel.org/all/20250708151946.374349-1-detlev.casanova@collabora.com/ \o/

16:47 <Ermine> \o/

17:02 <linkmauve> CyReVolt, do { … } while (0) is a common C pattern used in macros to make it behave like a normal function call, to require a semicolon at the end and to disallow any other way of calling it.

17:03 <linkmauve> Welcome to the arcanes of C.

17:27 <CyReVolt> <linkmauve> "CyReVolt, do { … } while (0..." <- yea multiple people have told this to me now, I was so not aware of it haha

17:27 <CyReVolt> it's as cursed as my appreciation for the hack^Wfine engineering solution