06:51 <mwalle> NishanthMenon: thanks, but it seems that except for the wording of the commit messages, there only the missing whitespace and maybe the order "kmalloc() and device_get_match_data()" legit

06:51 <mwalle> its quite verbose

06:52 <NishanthMenon> yeah many of the comments are subjective - i leave that to subsystem maintainers to make sense of

06:53 <NishanthMenon> kontron,smarc-sam67 instead of kontron,sam67 - that kinda is nice.. but depends on your product strategy

06:54 <NishanthMenon> i have'nt looked closer at fixed-regulators and interrupts-extended though

06:55 <NishanthMenon> another thing is the ordering per dt-coding-style.. i usually try and ensure it meets that guideline. i noticed that the patchwise had'nt picked that as a prompt .. so sent https://github.com/qualcomm/PatchWise/pull/56 out..

07:01 <NishanthMenon> oh yeah, there was J722S_MCU_IOPAD(0x03C, PIN_OUTPUT, 0)/* (C1) MCU_MCAN1_TX */ -> all hex in lowercase, please

09:20 <mwalle> nah, its kontron,sa67, thats the codename for the complete productname

09:21 <mwalle> regarding the hex uppercase, can't find it, but I've copied it over from some TI files :) probably downstream, because personally i prefer lowercase hex

09:21 <mwalle> the interrupts for the fixed regulator are even described in the binding :)

09:22 <mwalle> so, what that comment was complete nonsense

09:23 <mwalle> iirc the dt-coding-style leave the ordering of the nodes (not the properties) up to the soc maintainer. either alphabetically or by the order they appear in the dtsi

09:29 <mwalle> also that reg property is bogus

09:30 <mwalle> name-N doesn't get one

16:49 <Kubu_work> mwalle: Hello, is your "AM67A: Power-off sequence from linux to PMIC" workaround:

16:49 <Kubu_work> "As a workaround we'll just skip the power-off of the DM and let linux do the power-off via PMIC (and not via PSCI)."

16:49 <Kubu_work> https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1502423/am67a-power-off-sequence-from-linux-to-pmic/

16:49 <Kubu_work> is actually : https://lore.kernel.org/all/20250826134631.1499936-4-mwalle@kernel.org/ ?

16:50 <Kubu_work> I have some issue to poweroff a custom board (J721e): https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1557731/sk-tda4vm-is-sys_mcu_pwrdn-wkup_gpio0_55-pin-actually-used