michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 7.1.1 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
secondcreek has joined #ffmpeg-devel
<ramiro>
haasn: how many faces do your dice have? :)
Traneptora has joined #ffmpeg-devel
Traneptora has quit [Remote host closed the connection]
minimal has quit [Quit: Leaving]
cone-542 has quit [Quit: transmission timeout]
Anthony_ZO has joined #ffmpeg-devel
BradleyS has quit [Quit: quit]
sepro has quit [Ping timeout: 252 seconds]
sepro has joined #ffmpeg-devel
BradleyS has joined #ffmpeg-devel
beastd has quit [Ping timeout: 260 seconds]
beastd has joined #ffmpeg-devel
beastd has quit [Ping timeout: 268 seconds]
beastd has joined #ffmpeg-devel
secondcreek has quit [Remote host closed the connection]
secondcreek has joined #ffmpeg-devel
mkver has quit [Ping timeout: 244 seconds]
jamrial has quit []
Martchus has joined #ffmpeg-devel
Martchus_ has quit [Ping timeout: 265 seconds]
_whitelogger has joined #ffmpeg-devel
Anthony_ZO has quit [Ping timeout: 260 seconds]
Anthony_ZO has joined #ffmpeg-devel
<fflogger>
[editedticket] Gyan: Ticket #11610 ([swscale] scale with reference prevents video to be scaled with a second scale filter instance) updated https://trac.ffmpeg.org/ticket/11610#comment:1
System_Error has quit [Remote host closed the connection]
System_Error has joined #ffmpeg-devel
<Lynne>
michaelni: -level 4 is broken right now because of CRC ref issues in the extradata
<Lynne>
the parser has not been updated
<haasn>
ramiro: I had a left over d18446744073709551615 lying around from my pathfinder days
aw-cloud has quit [Remote host closed the connection]
<michaelni>
Lynne, "-vcodec ffv1 -strict -2 -level 4" works here, also theres a patch from andreas on the ML to fix a crcref issue not sure thats what you refer to
mkver has joined #ffmpeg-devel
zsoltiv has quit [Ping timeout: 248 seconds]
zsoltiv_ has quit [Ping timeout: 252 seconds]
zsoltiv_ has joined #ffmpeg-devel
zsoltiv has joined #ffmpeg-devel
<microchip_>
ffmpeg errors out when there's a : in the file name :/
<Lynne>
michaelni: it fails here
<Lynne>
git master, right?
cone-561 has joined #ffmpeg-devel
<cone-561>
ffmpeg Andreas Rheinhardt master:a6bcc773b5aa: avcodec/ffv1enc: Fix explicitly set -slicecrc 2
<cone-561>
ffmpeg Andreas Rheinhardt master:1c78db8ffc6f: avcodec/vc2enc: Use LUT to avoid repeated av_log2()
<cone-561>
ffmpeg Andreas Rheinhardt master:54c865fbec6f: swscale/utils: Fix potential race when initializing xyz tables
<mkver>
Lynne: Did you set the slicecrc option explicitly (to 2)?
<mkver>
If so, then your issue should have been fixed in a6bcc773b5aa3ad which I just applied.
<Lynne>
what does Video for Windows have to do with this, though?
<mkver>
Lynne: Namely, if the extradata size before being muxed into Matroska is odd, the current demuxer will export it with an additional byte at the end, breaking checksums.
<mkver>
Lynne: We do not store Matroska in its native, V_FFV1 form, but as VfW. Because using the latter might have created files incompatible with older demuxers.
<mkver>
Changing this is the third patch of said patchset.
<Lynne>
ah, and all other codecs don't care about the extradata total size, just that its large enough
<mkver>
Seems so.
<mkver>
For FFV1 version 3 the CRC is zero, which is not affected by appending a zero byte.
<mkver>
Btw: There is a discussion about whether we should switch to V_FFV1.
<mkver>
I think Zhao Zhili did not deem it possible that a BSF could change output codec id.
<TheVibeCoder>
thing is if i set bsf to not change codec id decoders still work
<TheVibeCoder>
because there are special decoders for it
<TheVibeCoder>
so on that side its cargo culted non-sense
<TheVibeCoder>
but regression is still there even though for media100 decoder and others there is workaround
<TheVibeCoder>
what is correct way to do this? change bsf to not change codec id and fix this regression that mkver pointed out?
<fflogger>
[editedticket] oldshev: Ticket #11610 ([swscale] scale with reference prevents video to be scaled with a second scale filter instance) updated https://trac.ffmpeg.org/ticket/11610#comment:2
<TheVibeCoder>
or if regression is fixed than bsfs must really change codec id?
<mkver>
TheVibeCoder: IMO we should not update the externally visible extradata at all; instead, decoders there should be a no-ownership pointer in AVCodecInternal pointing to the actual extradata (it is set to the initial, user-supplied extradata when avcodec_open2() and set to the output-extradata of the BSF if there is one. Decoders that may use a BSF changing extradata need to use AVCodecInternal.extradata; all the others can continue as now.
<mkver>
1c170613975d3cbcbb5aaa469b4a3cf0df5d4c2b would then be reverted.
<mkver>
s/decoders there should be/there should be/
<TheVibeCoder>
also please someone add media100 coverage to FATE
<jamrial>
do we really need a separate decoder for media100 if it's going to be converted to mpegb?
<TheVibeCoder>
looks like yes
<jamrial>
we could maybe try to make it so the bsf is only inserted if the input data is recognized as media100
<TheVibeCoder>
because it triggers bsf in its spec
TheVibeCoder has quit [Quit: Client closed]
TheVibeCoder has joined #ffmpeg-devel
<TheVibeCoder>
that is over-engineering, the normal data is properly signaled by fourcc
<TheVibeCoder>
its just there to not duplicated decoders code, but still separate codec_id should be there because bitstream is not compatible even though its basically modified mjpeg-b
<TheVibeCoder>
so media100, ahx (mp2 variant), wwvorbis (wwise vorbis variant) are currently bitten by this
<TheVibeCoder>
- ahx is CRI mpv2 variant, those game formats are sometimes ridiculous
<TheVibeCoder>
*mp2
<TheVibeCoder>
and none of them modify extradata, vvc is so huge that I do not dare to peek at it
<fflogger>
[newticket] gabriel: Ticket #11611 ([avformat] VVC in MKV container: IDRs with leading pictures not decoded correctly) created https://trac.ffmpeg.org/ticket/11611
<fflogger>
[editedticket] Balling: Ticket #9471 ([avformat] EAC3 native encoder is only gapless in the beginning, not in the end) updated https://trac.ffmpeg.org/ticket/9471#comment:10
cone-344 has joined #ffmpeg-devel
<cone-344>
ffmpeg Andreas Rheinhardt master:92e310eb82e0: avformat/matroskadec: Fix VfW extradata size
<ramiro>
wbs: last year I did a bunch of improvements on neon yuv2rgb, but in the end it became an overhaul of the neon code. I said to myself that some day I would split that into separate commits and submit for review, but now that I look back at the code, it seems like a lot of work to split into smaller functional commits. do you think I could submit the overhaul, or is it best to try and split it, for
<ramiro>
commit history's sake and make review easier?
odrling has quit [Remote host closed the connection]
odrling has joined #ffmpeg-devel
Kei_N_ has joined #ffmpeg-devel
Kei_N has quit [Ping timeout: 260 seconds]
<kierank>
thardin: indeed unmanageable to read all that
<thardin>
lots of traffic. which is good I guess. but also not LKML levels
s55 has quit [Ping timeout: 248 seconds]
<kierank>
mostly noise imo
<kierank>
maybe swscale is the exception
<thardin>
haasn is love. haasn is life
<thardin>
I had some ideas earlier today how to improve the throughput of the cinepak encoder, for the CD decoder usecase. because I know at least one group of users want that. you want near constant bitrate there, which has some implications
<thardin>
I have some VQ patches that I haven't bothered sending to the ML
<thardin>
which would speed up all VQ encoders
s55 has joined #ffmpeg-devel
<cone-344>
ffmpeg Timo Rothenpieler master:4cb42551d4ad: fftools/resources: add missing extensions to .gitignore
<cone-344>
ffmpeg Timo Rothenpieler master:af943831248d: ffbuild: correctly silence and tag new css/html steps
<cone-344>
ffmpeg softworkz master:aa38270630f5: fftools/makefile: Remove resources from ffprobe