<SiFuh_>
farkuhar: shellcheck complains about /sbin/fsck $FORCEFSCK -A -T -C -a SC2086 (info): Double quote to prevent globbing and word splitting.
<farkuhar>
SiFuh_: Yes, but have you tried running /sbin/fsck with an empty string as the first argument? In my tests it always has nonzero exit status.
<farkuhar>
Hence it's helpful to insert "#shellcheck disable=SC2086" right above that line, to suppress the spurious shellcheck output.
<farkuhar>
Another alternative is to avoid defining a new variable, and just write out in full the two possible /sbin/fsck commands, as `then` and `else` branches of the conditional that begins `if [ -f /forcefsck ]`
<farkuhar>
More than just nonzero exit status, in fact. The frightening error message that takes up a full console screen is only activated with fsck exit status greater than 1 (e.g., 4=filesystem errors left uncorrected, 16=usage/syntax error).
<farkuhar>
"Skipping invalid mount point: 0" <- this message comes from parsing /proc/mounts too greedily?
<SiFuh_>
Maybe
<SiFuh_>
if [[ ! -d "$mountpoint" && ! -f "$mountpoint" ]]; then
<SiFuh_>
printf "%s %s\n" "Skipping invalid mount point:" "$mountpoint"
<SiFuh_>
continue
<SiFuh_>
fi
<SiFuh_>
It doesn't need to tell you. I added it in for debug purposes
<farkuhar>
In the `while read` loop where you added it, mountpoint is the second field of a space-separated line from /proc/mounts. Then in your screenshot I see "Skipping invalid mount point: 0", so there must have been a line in /proc/mounts whose second field was just 0?
<SiFuh_>
Let me look. I was doing other stuff to do with the shutdown part. Waiting for it to reboot
<SiFuh_>
I have a feeling, I am pretty much done.
<SiFuh_>
I didn't put rc.fix in it though. Just sourcing it
<SiFuh_>
farkuhar: _ mountpoint fstype _ <-- here
<SiFuh_>
farkuhar: Don't know. Maybe something to do with IFS
<SiFuh_>
No worries, I will log everything and have a look at the logs. Might just need to put "$mountpoint" == "0" in the lines to skip.
<SiFuh_>
farkuhar: So as I see it, if you select USE_COLOR=false, you still get Bold white text
ppetrov^ has quit [Quit: Leaving]
ppetrov^ has joined #crux-social
ppetrov^ has quit [Quit: Leaving]
SiFuh has quit [Remote host closed the connection]